-
-
Notifications
You must be signed in to change notification settings - Fork 252
Fix ignore_keys issue in detailed__dict__ #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation to prevent traversing dunder attributes via check_elem() - Harden Delta class against malicious pickle payloads - Make SAFE_TO_IMPORT a frozenset for immutability - Add comprehensive security tests in test_security.py - Prevent access to __globals__ and other dangerous attributes
- Update version to 8.6.1 across all files - Add security vulnerability notes to CHANGELOG and README - Update AUTHORS.md to credit security reporter - Update documentation with security fix information
adding security tests and a patch for the class pollution and remote code execution
If `key` is not in result, then there's no point in trying to delete it anyway
Hi @vitalis89
- Please merge our dev branch back to your branch and push again since the PR is showing other non-relevant stuff that were already on the master branch when you started working on this.
- I am not following your logic.
ignore_keysis typically much smaller than__dict__so it is a performance hit to dofor key in obj.__dict__:. Not sure what we are gaining by this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
keyis not in result, then there's no point in trying to delete it anyway