Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

promote to stable #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travi wants to merge 49 commits into master
base: master
Choose a base branch
Loading
from beta
Open

promote to stable #1017

travi wants to merge 49 commits into master from beta

Conversation

Copy link
Member

@travi travi commented Oct 16, 2025
edited
Loading

todo before merging

  • handle dry-run of publish for releases that happen from a sub-directory
  • refine messaging for auth failure errors

outstanding issues after this effort

  • (削除) add-channel will fail because of lack of OIDC support (削除ここまで) this appears to no longer be true (update: maybe still not fully in the clear, with limited cases hitting issues that are on the registry side)
  • ci verification will not cover node v24. resolving this may warrant switching test frameworks, which is beyond the scope of adding trusted publishing capabilities

travi added 30 commits July 8, 2025 23:49
since oidc does not currently work for whoami
for #958 
BREAKING CHANGE: v25 of semantic-release is now expected
for #958 
...m various registriess
the trusted publishing verification is incomplete, but this change wires the various options
together, at least
for #958 
...ge can succeed
this is the correct call, but details are still incomplete since the bearer token for the request
needs to be the OIDC token from the CI IdP
for #958 
travi and others added 16 commits October 15, 2025 00:39
...b actions
for both trusted publishing and provenance attestations
for #958 
since that logic is now handled with the step to acquire the id-token
for #958 
since stubbing `@actions/core` breaks in that version and i don't want figuring that out to delay
getting the trusted-publishing feature out
for #958 
@travi travi marked this pull request as draft October 16, 2025 03:20
Copy link
Member Author

travi commented Oct 16, 2025
edited by hearts bot
Loading

@semantic-release/maintainers feel free to start reviewing this. there are a few final details that need to be resolved, but this is mostly ready to go. i'd like to get this promoted by the end of the week

Copy link

🎉 This PR is included in version 13.1.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 13.1.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@travi travi marked this pull request as ready for review October 18, 2025 15:31
Copy link
Member Author

travi commented Oct 18, 2025
edited
Loading

@semantic-release/maintainers based on early feedback from #958 and my tests in https://github.com/travi-test/npm-oidc-test/ and our automated tests running in our pipeline, i'm ready to say this is ready for final review before promoting to stable.

the outstanding issues in the initial PR description have been updated to remain accurate and are beyond the scope of what i think should hold this PR back from being merged

this should be merged with a normal merge rather than being squashed

Copy link
Member

@babblebey babblebey left a comment
edited by hearts bot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @travi 👍🏾

Ready when you're ready... Let's go!

Just curious though... I see the Pattern where we're doing some things to orchestrate the OIDC session with the specific CI i.e. (GitHub Actions and GitLab Pipelines)... Is this the kinda pattern we get to follow if we want to support OIDC in other CI environments?? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@babblebey babblebey babblebey approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /