This repository was archived by the owner on Jun 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Replacing the secp256k1 library #167
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md#0140---2019年07月08日
@AvishaiW @moriaab
P.S. maybe moving the Context to a global lazy_static!
would be better. because the context is a one time slow creation that then makes everything really fast, and it's thread safe, so no need even for a Mutex.
(so either lazy_static, or something like: https://github.com/elichai/ecc-secp256k1/blob/master/src/secp256k1.rs#L480)
Thank you so much @elichai
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This is more of a PoC for @AvishaiW or @moriaab to do in the future.
(削除) this should wait till after rust-bitcoin/rust-secp256k1#115 (削除ここまで)https://enigmaco.atlassian.net/browse/EP-612
(削除) Replacing libsecp256k1 with rust-secp256k1 makes it not compile to WASM.we should either investigate it further, Or feature gate between them
(another possibility is to outright not use it in wasm and maybe provide other crypto in a wasm specific program or provide these as external in the runtime) (削除ここまで)