Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jun 21, 2020. It is now read-only.

Replacing the secp256k1 library #167

Draft
elichai wants to merge 1 commit into develop
base: develop
Choose a base branch
Loading
from secp256k1
Draft

Replacing the secp256k1 library #167

elichai wants to merge 1 commit into develop from secp256k1

Conversation

Copy link
Contributor

@elichai elichai commented May 28, 2019
edited
Loading

This is more of a PoC for @AvishaiW or @moriaab to do in the future.
(削除) this should wait till after rust-bitcoin/rust-secp256k1#115 (削除ここまで)

https://enigmaco.atlassian.net/browse/EP-612

(削除) Replacing libsecp256k1 with rust-secp256k1 makes it not compile to WASM.
we should either investigate it further, Or feature gate between them
(another possibility is to outright not use it in wasm and maybe provide other crypto in a wasm specific program or provide these as external in the runtime) (削除ここまで)

@elichai elichai requested review from AvishaiW and moriaab May 28, 2019 14:40
Copy link
Contributor Author

elichai commented Jul 16, 2019
edited
Loading

FYI https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md#0140---2019年07月08日
@AvishaiW @moriaab

P.S. maybe moving the Context to a global lazy_static! would be better. because the context is a one time slow creation that then makes everything really fast, and it's thread safe, so no need even for a Mutex.
(so either lazy_static, or something like: https://github.com/elichai/ecc-secp256k1/blob/master/src/secp256k1.rs#L480)

Copy link
Contributor

moriaab commented Jul 17, 2019

Thank you so much @elichai

elichai reacted with laugh emoji

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AvishaiW AvishaiW Awaiting requested review from AvishaiW

@moriaab moriaab Awaiting requested review from moriaab

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /