-
Notifications
You must be signed in to change notification settings - Fork 12
include CKRecord.RecordType in deleted record ids
#2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jianhu – sorry I didn't get a notification for this PR. Thanks for the PR. I can see why you'd want this change. This will require a major version bump, but I will consider it. I need time to manually test it myself. In the meantime, I did make one code suggestion.
Comment on lines
+168
to
+172
if deletedRecordIDs[recordType] != nil {
deletedRecordIDs[recordType]?.append(recordID)
} else {
deletedRecordIDs[recordType] = [recordID]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if deletedRecordIDs[recordType] != nil {
deletedRecordIDs[recordType]?.append(recordID)
} else {
deletedRecordIDs[recordType] = [recordID]
}
deletedRecordIDs[recordType, default: []].append(recordID)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it might be useful to include record type information in deleted records when doing fetch operation, so that once record type is known, we can do operation to that table directly, without maintaining some extra data.
for my use case it's kind of convenient, what do you think?