-
-
Notifications
You must be signed in to change notification settings - Fork 853
Remove asm_const attribute because it is no longer required
#220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove asm_const attribute because it is no longer required
#220
Conversation
jannic
commented
Oct 18, 2024
If we rely on recent features, we probably need to update https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/rust-toolchain.toml as well.
ChocolateLoverRaj
commented
Oct 18, 2024
I updated the toolchain. As I go through the tutorials there are more things that need to be changed to work with the latest Rust version. Should I make a PR that updates all tutorials to work? Is there a shortcut for having to modify changes from 03 that also need to be changed from 04 to 20?
BartMassey
commented
Oct 23, 2024
I would suggest that you fork this tutorial and work on a branch, fixing things as you go with one commit per fix. Then submit a PR to bring your branch to mainline and we can discuss it.
Uh oh!
There was an error while loading. Please reload this page.
Description
I got this error:
so I removed the line and created this PR. I tested it in QEMU and it worked. Real HW raspberry Pi is not applicable since it's just tutorial 2.
Pre-commit steps
./contributor_setup.shfollowed by./devtool ready_for_publishRubywithBundlerandNPMinstalled locally../devtool ready_for_publish_no_rustcan be used instead (faster).