-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[tgaxis] add epsilon for ticks counts #20131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When caclucating number of extra ticks which need to be placed on left or right side of axis add `epsilon` to avoid possible rounding problems. Ensure that minor tick on very begin or very end of axis range is painted
Test Results
20 files 20 suites 3d 15h 27m 26s ⏱️
3 692 tests 3 691 ✅ 0 💤 1 ❌
72 044 runs 72 039 ✅ 0 💤 5 ❌
For more details on these failures, see this check.
Results for commit 17ab5a9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating number of extra ticks
which need to be placed on left or right side of axis
add
epsilon
to avoid possible rounding problems.Ensure that minor tick on very begin or very end of axis range is painted
Solves problem in
stressGraphics
with two tests where very first minor tick may not appear on some platforms.