-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[main] hadd: properly handle help flag and add tests #20121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@silverweed
silverweed
requested review from
bellenot and
pcanal
as code owners
October 16, 2025 07:12
Test Results
22 files 22 suites 3d 20h 12m 3s ⏱️
3 697 tests 3 696 ✅ 0 💤 1 ❌
79 383 runs 79 378 ✅ 0 💤 5 ❌
For more details on these failures, see this check.
Results for commit d6441ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
makes hadd handle
-h,-helpor--helplike the other flags, i.e. accepting it in any valid position rather than just as the first flag.Note that we accept all versions because a user that requires help on the command shouldn't have to guess the proper form of the flag, we just accept all canonical ones.
Checklist: