-
Notifications
You must be signed in to change notification settings - Fork 181
Better intermediate output #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new "Communication during investigation" section to the general instructions template, defining when and how to pause and share findings during tool batches and task progression, emphasizing concise, critical updates and next steps. No public/exported interfaces are changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Investigator
participant ToolRunner as Tool Runner
participant Stakeholder as Stakeholder
Investigator->>ToolRunner: Execute tool batch
ToolRunner-->>Investigator: Results
note over Investigator,Stakeholder: New step: standardized pause-and-update
Investigator->>Stakeholder: Communicate concise findings + critical items + next steps
alt More work needed
Investigator->>ToolRunner: Proceed with next tasks/batch
else Sufficient findings
Investigator->>Stakeholder: Finalize/await direction
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
holmes/plugins/prompts/_general_instructions.jinja2(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
holmes/plugins/prompts/**/*.jinja2
📄 CodeRabbit inference engine (CLAUDE.md)
Prompts must be stored as Jinja2 templates under holmes/plugins/prompts/{name}.jinja2
Files:
holmes/plugins/prompts/_general_instructions.jinja2
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: llm_evals
- GitHub Check: Pre-commit checks
🔇 Additional comments (1)
holmes/plugins/prompts/_general_instructions.jinja2 (1)
68-76: LGTM! Clear communication guidelines.This section provides valuable guidance for providing timely updates during investigations. The instructions are clear, concise, and include a helpful example. The placement between task management and tool calls is logical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar fix needed.
Missing comma before "not" for clarity.
Apply this diff:
-* Focus on critical discoveries (errors, bottlenecks, root causes) not routine checks +* Focus on critical discoveries (errors, bottlenecks, root causes), not routine checks
📝 Committable suggestion
!!️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
🤖 Prompt for AI Agents
In holmes/plugins/prompts/_general_instructions.jinja2 around line 74, the
sentence "* Focus on critical discoveries (errors, bottlenecks, root causes) not
routine checks" is missing a comma for clarity; insert a comma after the closing
parenthesis so it reads "* Focus on critical discoveries (errors, bottlenecks,
root causes), not routine checks".
No description provided.