.gitignore (1)

4-4: Anchor ignore to repository root to avoid overmatching.

bin/ without a leading slash ignores any nested bin/ directory. If the intent is only the top-level Poetry bin, prefer /bin/.

Apply this diff:

-bin/
+/bin/

CONTRIBUTING.md (1)

11-11: Resolve tooling policy mismatch (docs vs Makefile).

Docs say "poetry 1.8.5 & up" but Makefile enforces exactly 1.8.5. Pick one:

• Option A (simpler): require exactly 1.8.5 in docs.
• Option B: relax Makefile check to accept >= 1.8.5.

Given this PR’s goal, Option A is likely intended. Suggested doc tweak:

- - poetry `1.8.5` & up
+ - poetry `1.8.5`

Makefile (4)

3-6: Ensure dev deps are installed before running hooks.

Local mypy hook uses poetry run mypy .; running pre-commit without ensuring deps are installed can fail on fresh clones.

Apply this diff to make check depend on deps-install:

-##@ Checks
-check: poetry
+##@ Checks
+check: poetry deps-install
 	${POETRY} run pre-commit run -a

---

16-25: Use build for strict docs CI, keep serve for local.

docs-strict running serve --strict is less CI-friendly than build --strict.

Apply this diff:

-docs-strict: poetry
-	${POETRY} run mkdocs serve --dev-addr=127.0.0.1:7000 --strict
+docs-strict: poetry
+	${POETRY} run mkdocs build --strict

Optionally add a separate target (nice-to-have):

docs-serve-strict: poetry
	${POETRY} run mkdocs serve --dev-addr=127.0.0.1:7000 --strict

---

36-44: Minor robustness: prefer CURDIR and add common phony/aggregator targets.

• Use Make’s built-in $(CURDIR) instead of $(shell pwd).
• Add .PHONY for new targets and common "all/test/clean" shims (helps checkmake and developer UX).

Apply this diff:

-POETRY = $(shell pwd)/bin/poetry
+POETRY = $(CURDIR)/bin/poetry
 POETRY_VERSION = 1.8.5
@@
-.PHONY: poetry
+.PHONY: poetry check test test-without-llm test-llm-investigate test-llm-ask-holmes docs docs-build docs-strict deps-install deps-lock
+.PHONY: all clean
+
+all: check
+
+test: test-without-llm test-llm-ask-holmes
+
+clean:
+	rm -rf $(CURDIR)/.venv $(CURDIR)/.mypy_cache $(CURDIR)/.pytest_cache $(CURDIR)/site
+
 poetry: ## Download poetry locally if necessary.
-	@if [ ! -f $(POETRY) ] || ! $(POETRY) --version | grep -q "$(POETRY_VERSION)"; then \
+	@if [ ! -f $(POETRY) ] || ! $(POETRY) --version | grep -q "$(POETRY_VERSION)"; then \
 		echo "Installing poetry $(POETRY_VERSION)"; \
-		curl -sSL https://install.python-poetry.org | POETRY_HOME=$(shell pwd) python3 - --version $(POETRY_VERSION); \
+		curl -sSL https://install.python-poetry.org | POETRY_HOME=$(CURDIR) python3 - --version $(POETRY_VERSION); \
 	fi

If you instead want docs’ "& up" policy, we can relax the version check to ">= 1.8.5" using a semantic compare. I can provide that snippet on request.

---

28-33: Lock command safety.

Consider poetry lock --no-update for deterministic lock refreshes when you only want to re-resolve from pyproject without bumping. If you do want updates, keep as-is.

-deps-lock: poetry
-	${POETRY} lock
+deps-lock: poetry
+	${POETRY} lock --no-update

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: nherment
PR: robusta-dev/holmesgpt#436
File: tests/llm/utils/mock_utils.py:240-249
Timestamp: 2025年06月05日T12:23:27.634Z
Learning: The holmesgpt project uses Python >= 3.10 and prefers modern type hint syntax like `list[str]`, `dict[str, int]` over importing equivalent types from the typing module like `List[str]`, `Dict[str, int]`.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro