Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CFB mode segmentSize bug fix #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shanmukhateja wants to merge 2 commits into ricmoo:master
base: master
Choose a base branch
Loading
from shanmukhateja:fix-issue-29

Conversation

Copy link

@shanmukhateja shanmukhateja commented May 23, 2020

Fixes #29

Sniper1h reacted with thumbs up emoji
Copy link

sw6ueyz commented Sep 30, 2025

Please check your code again.
It will completely disable segment size validation since (n * S) % S === 0, the error will never occur.
It seems like the fix should be something like this:

if ((plaintext.length * 8) % this.segmentSize !== 0)

Copy link
Author

Hi @sw6ueyz

I do not remember why this change was needed and frankly I do not need it anymore.

Feel free to make changes as you see fit. I won't be able to help with this. It's been 5 years :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CFB encryption/decryption segment size error may be incorrect

AltStyle によって変換されたページ (->オリジナル) /