-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Feat: Add Missing AsciiDoc Blockquotes to Markdown Editor #7390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the 'success' blockquote from Markdown should be ported across to AsciiDoc.
I'll look into it again. I couldn't find where the asciidoc styles were coming from. Asciidoc in general, though, doesn't natively support SUCCESS so it would need to be a custom addition.
For consistency, the 'success' blockquote from Markdown should be ported across to AsciiDoc.
I'm still checking this out, but I'm currently stumped finding out where the admonition css class is being set. Once I can figure that out I believe everything will be in parity.
...o fix corner radii not rendering
...or.js currently doesn't support inline extensions on paragraph content
I have finished working to get .md and .adoc editors in parity. One thing to note is that AsciiDoctor.js does not support inline extensions which would allow for the creation of a SUCCESS: option. To get around this a Block extension was created and the editor was modified accordingly.
When you click on the Success Blockquote option now it generates:
[SUCCESS]
There is a new file: asciidoc-extended.js in the client modules that includes the code for creating the new admonition block and it is registered as an extension where asciidoctor is invoked.
...d corners. Updated rest of admonition block styles to explicitly set the background color to transparent Signed-off-by: Brian Powell Jr <b.powell.jr@outlook.com>
7c72235 to
32750e0
Compare
@NGPixel I know you're a busy person, but could you review this when you have a moment. I'd like to have this merged in for use in the sites I have wiki.js deployed.
@alswikiorg
alswikiorg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I was just thinking, since this is a feature improvement should I close this PR and recreate it for the Vega branch?
wiki-js-markdown-blockquote-PR