Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix ObjC Support iteration #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jsflax wants to merge 9 commits into master
base: master
Choose a base branch
Loading
from jf/fix-objc-support-iteration
Draft

Conversation

Copy link
Contributor

@jsflax jsflax commented Oct 26, 2021

Fixes #7490.

Copy link
Contributor

This needs a changelog entry

@jsflax jsflax requested review from leemaguire and removed request for leemaguire October 27, 2021 12:26
Copy link
Member

tgoyne commented Oct 27, 2021

This needs tests which actually test that the bug that the user reported is fixed.

@jsflax jsflax requested review from tgoyne and removed request for tgoyne October 27, 2021 16:32
Copy link
Member

tgoyne commented Oct 28, 2021

There is a whole suite of tests for using the obj-c API from Swift and this should be tested there, not in an unrelated place.

Copy link
Contributor Author

jsflax commented Oct 28, 2021

@tgoyne ptal.

@jsflax jsflax self-assigned this Oct 29, 2021
Copy link
Contributor Author

jsflax commented Oct 29, 2021

Nevermind, seeing some build failures on CI.

Copy link
Contributor Author

jsflax commented Nov 12, 2021

@tgoyne PTAL.

### Fixed
* Fix `RLMCollectionIterator` where `RLMCollectionIterator` contents were not RLMObject.
This is for users using the optional `RLMSupport.swift` file.
* Change default request timeout for `RLMApp` from 6 seconds to 60 seconds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad changeset merge.

@stoneyMDB stoneyMDB marked this pull request as draft July 12, 2022 15:23
Copy link

What is the status on this? It happens for me as well.
Bogdan-Belogurov and ArtemBurmistrov reacted with thumbs up emoji Bogdan-Belogurov reacted with rocket emoji

Copy link

I'm having the same thing over and over again
ArtemBurmistrov reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgoyne tgoyne tgoyne approved these changes

@leemaguire leemaguire leemaguire approved these changes

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crashes when accessing the RLMArray<RLMEmbeddedObject> element

AltStyle によって変換されたページ (->オリジナル) /