Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bug fix last slide not visible when loop true #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aravindemmadishetty wants to merge 1 commit into rcbyr:master
base: master
Choose a base branch
Loading
from aravindemmadishetty:master

Conversation

Copy link

@aravindemmadishetty aravindemmadishetty commented Jul 26, 2023
edited
Loading

vincentorback reacted with thumbs up emoji hc-chumak reacted with eyes emoji
Copy link

@rcbyr could you please consider merging this PR?

Copy link
Owner

rcbyr commented Oct 1, 2023

Thanks for your PR. But it doesn't work. Even if the last slide is displayed correctly, the first slide will then disappear. The problem has only been relocated. Since the slider does not duplicate slides, it probably does not make sense to activate the loop if there are too few slides. In this case there is enough space in the viewport to display all slides anyway.

Copy link
Author

What you said is true, but I want the loop because the slides in the slider are dynamic. so I want this functionality. Can you please see if you can add this scenario ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /