-
-
Notifications
You must be signed in to change notification settings - Fork 608
Add support for custom app menu items on macOS #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the ability to add custom menu items to the macOS application
menu (the first menu in the menu bar) using the special '__app__' menu title.
Custom items are placed between "About" and "Services" menu items,
surrounded by separators. On non-macOS platforms, '__app__' menus are
silently ignored.
Usage:
app_menu = Menu('__app__', [
MenuAction('Preferences...', open_preferences),
MenuSeparator(),
MenuAction('Check for Updates', check_updates)
])
webview.create_window('App', menu=[app_menu, file_menu])
Changes:
- cocoa.py: Process '__app__' menus and insert items into app menu
- gtk.py, qt.py, winforms.py: Ignore '__app__' menus on other platforms
- Added comprehensive example: examples/app_menu_test.py
Please integrate app menu example into examples/menu.py, but otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR implements support for adding custom menu items to the macOS application menu (the first menu in the menu bar that displays the app name).
Implementation
Custom items are added using the special
__app__menu title:Behavior
macOS (Cocoa)
Custom items are inserted into the application menu between "About" and "Services", surrounded by separators:
Other Platforms
Menus with title
__app__are silently ignored (no error, no rendering).Changes
__app__menus and insert items into app menu_add_app_menu()to accept optional custom items_recreate_menus()to filter and extract__app__menu items_process_menu_items()method__app__menusTesting
Run the example on macOS:
The application menu should display custom items between "About" and "Services".
Related Issue
Implements the feature request discussed in: #1725