-
Notifications
You must be signed in to change notification settings - Fork 412
[Refactor] Refactor GRPO as a separate class #3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3205
- 📄 Preview Python docs built from this PR
Note: Links to docs will display an error until the docs builds have been completed.
❌ 4 New Failures, 1 Cancelled Job, 1 Unrelated Failure
As of commit 20e65b6 with merge base bd93f13 (image ):
NEW FAILURES - The following jobs have failed:
- Continuous Benchmark (PR) / CPU Pytest benchmark (gh)
Process completed with exit code 1. - Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
RuntimeError: Command docker exec -t 6298ae47d4307ade781260e8952a92b3e582fc4f8addca31c26a8e220dba6c36 /exec failed with exit code 1 - Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh)
RuntimeError: SumSegmentTreeFp32 is not available. See warning above. - Lint / python-source-and-configs / linux-job (gh)
RuntimeError: Command docker exec -t 3ca959c54f82133a5bcb0b7553ae52fe603f3854afad8749749b6d4d7e3cd82e /exec failed with exit code 1
CANCELLED JOB - The following job was cancelled. Please retry:
- Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
##[error]The operation was canceled.
BROKEN TRUNK - The following job failed but were present on the merge base:
👉 Rebase onto the `viable/strict` branch to avoid these failures
- LLM Tests on Linux / unittests (3.9, 12.8) / linux-job (gh) (trunk failure)
##[error]The operation was canceled.
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@meta-cla
meta-cla
bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 16, 2025
This was referenced Oct 16, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Stack from ghstack (oldest at bottom):