Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support attaching arbitrary binary files #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eqvinox wants to merge 1 commit into pytest-dev:master
base: master
Choose a base branch
Loading
from opensourcerouting:bin-attach

Conversation

Copy link

@eqvinox eqvinox commented May 7, 2021

(Our testcases produce wireshark pcap files...)

Copy link
Contributor

Does it really makes sense to add this in a self-contained report?

Copy link
Author

eqvinox commented Jan 26, 2022

Does it really makes sense to add this in a self-contained report?

For any network-heavy software being tested, pcap files are equivalent (if not above) in importance to logfiles, so I don't really have any doubt in a "yes" to that. Especially since that's just one (pretty wide) use case, there's probably a bunch of others. Trying to think of some others, testing (de-)serialization feels like something where attaching random binaries would be pretty useful too.

BeyondEvil reacted with thumbs up emoji

Copy link
Contributor

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.

But maybe I'm misunderstanding something here? @eqvinox

Copy link
Author

eqvinox commented Jan 26, 2022

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.

But maybe I'm misunderstanding something here? @eqvinox

@BeyondEvil when you click the link for the file, the browser will open a file download dialog and save it decoded. (The download dialog would probably list wireshark too, as an application to directly open the file with. The file is first saved to /tmp for that, same way all "open with" downloads work.)

@BeyondEvil BeyondEvil added the next-gen Candidate for the next-gen project label Jan 26, 2022
Copy link
Contributor

Ah, got it. Ok, I'll add this to next-gen. Thanks!

eqvinox reacted with thumbs up emoji

Copy link
Contributor

Missed this is during initial work of v4. Will try to get to it now.

Copy link
Contributor

How would you consume that pcap file from the self-contained report? It's going to be base64 encoded.
But maybe I'm misunderstanding something here? @eqvinox

@BeyondEvil when you click the link for the file, the browser will open a file download dialog and save it decoded. (The download dialog would probably list wireshark too, as an application to directly open the file with. The file is first saved to /tmp for that, same way all "open with" downloads work.)

I'm not seeing the behavior described here.

When I click the link, it just opens a new tab displaying the path to the binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

next-gen Candidate for the next-gen project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /