-
Notifications
You must be signed in to change notification settings - Fork 51
Allow apt mirrors #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow apt mirrors #375
Conversation
Again, thanks for this MR, that could be useful to many users.
Would you mind extending this idea a little, please ?
- If we want to let the user replace
deb.debian.org
by another mirror, then we need to organise this differently, IMHO. For instance, by creating amirror
variable, with the default beingdeb.debian.org
, and then, allow the users to override them. - Second, as this is a very sensitive value, then I would like to check that the value is valid before deploying the sources.list file, for instance by downloading first the release file (e.g.
https://debian.mirror.serversaustralia.com.au/debian/dists/bookworm/Release
) - Last but not least, documentation will need to mention this at least.
Again, thanks for your idea, I never thought about this.
a5ca7af
to
029bff1
Compare
-
Added
mirror
variable to 'system settings' of eachconfig/defaults/version-*.yml
file, added discriptive comment. -
My skills at
ansible
are not very strong, so maybe checking code could be done more efficiently, but it passes:
ROLE=bootstrap ansible-playbook -e version=small check.yml
...
TASK [bootstrap : Initialise and update the packages repository] ***********************************
included: ~/Projects/homebox-all/homebox/roles/bootstrap/tasks/check/apt.yml for homebox
TASK [bootstrap : Check apt mirror is valid for us] ************************************************
ok: [homebox] => (item=bookworm)
ok: [homebox] => (item=bookworm-updates)
ok: [homebox] => (item=bookworm-backports)
TASK [bootstrap : Check if we can run apt update without error] ************************************
...
- Added to section System settings which is IMO self descriptive. Also I'am not sure how to rebuild
readthedocs
.
Thank you!
Sorry for the late answer, I will check this asap.
@progmaticltd, I've implemented everything as discussed.
Hello, diffway, sorry for the late answer.
Thank you very much, I am testing it right now, and I will come back to you.
The only issue I found so far, is the fact that https
does not work with all the mirrors.
Actually, don't do anything, I can automatically detect if the mirror is only compatible with http and write the template accordingly.
@arodier could you kindly make a decision about those conflicts?
I honestly doesn't understand what I'm supposed to do:
the file docs/30-define-your-config.md
is gone in progmaticltd:dev
the file roles/bootstrap/vars/main.yml
looks fine to me.
Sorry, I neglected this issue, I will come back to it in a few days, during holidays.
No description provided.