-
Notifications
You must be signed in to change notification settings - Fork 898
feat: adds swayosd #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds swayosd #1818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the title with "feat: adds swayosd"
@kRHYME7 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add show_percentage = true, latest build suports it
I don't know if I can merge this. I won't even touch his keybindings, which uses the scripts .
Title is misleading we are not adding swayosd, but we are replacing Tittus configs now.
I will suggest making this an optional package (Not all is using chaotic-aur)
I can merge these only If I don't mess up his config. We can add a Markdown for extending HyDE capability, in which I am trying to do with Hyprpanel.
- We can add this to
restore_cfg.lstN|Y|${HOME}/.config/swayosd|config.toml | swayosd-git - add
swayosd-gittocustom_app.lstinstead ofcustom_hypr.lst - for backlight and pulseaudio waybar modules we can all just add another module but with tags
pulseaudio#swayosd.jsoncandbacklight#swayosd.jsoncand users can add those#swayosdin the ./waybar./config.ctl` If we can provide theme a wiki.
Sorry, this might be an inconvenience, but the owner is always trying to lessen the repo's dependencies.
I checked hyprpanel. Looks good. It also has an osd , are we gonna switch from waybar to that? or will there be an option to choose
No options on intallation yet but an extensive wiki for extension yes. (Hope so).
I don't know if I can merge this. I won't even touch his keybindings, which uses the scripts . Title is misleading we are not adding swayosd, but we are replacing Tittus configs now.
I will suggest making this an optional package (Not all is using chaotic-aur)
I can merge these only If I don't mess up his config. We can add a Markdown for extending HyDE capability, in which I am trying to do with Hyprpanel.
- We can add this to
restore_cfg.lstN|Y|${HOME}/.config/swayosd|config.toml | swayosd-git- add
swayosd-gittocustom_app.lstinstead ofcustom_hypr.lst- for backlight and pulseaudio waybar modules we can all just add another module but with tags
pulseaudio#swayosd.jsoncandbacklight#swayosd.jsoncand users can add those#swayosdin the ./waybar./config.ctl` If we can provide theme a wiki.Sorry, this might be an inconvenience, but the owner is always trying to lessen the repo's dependencies.
i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore
i tested HyprPanel today...it works fine but have some minor bugs yet
image
i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore
How about leaving the pulseaudio and backlight as is and make a separate module for swayosd?
i changed that things you said except pulseaudio#swayosd.jsonc and backlight#swayosd.jsonc...i think if anyone choose to use swayosd doesnt need custom osd anymore
How about leaving the pulseaudio and backlight as is and make a separate module for swayosd?
i understand what you say and why...i will work on it in this weekend and if you have any idea to how separate this two configs well pls share with us because we have conflict with keybindings too
Sure Sure. Will Edit the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this if we start swayosd-server and invoke using swayosd-client
btw @TheyCallMeSecond can you also compare the memory usage of hyprpanel and waybar. I am skeptical on the memory part of hyprpanel as its on typescript afaik
Also hyprpanel has inbuilt osd https://hyprpanel.com/configuration/osd.html so swayosd would not be needed i guess
I was afraid of that, thats like twice the memory. Because typescript is not so great on memory . I think I will stick to waybar for now
This repo will always use waybar by default unless tittu will change it.
What I can do is to make integration with external dotfiles to hyde. I'm looking forward to swayosd as this one requires minimal change. ie the volume and backlight script PR. that one doesn't require extra configuration for the users.
This repo will always use waybar by default unless tittu will change it.
What I can do is to make integration with external dotfiles to hyde. I'm looking forward to swayosd as this one requires minimal change. ie the volume and backlight script PR. that one doesn't require extra configuration for the users.
yeah. hyprpanel is a big change.
Hyprpanel is built over ags,
Hyprpanel is built over ags,
yeah . But depends if how much you can customize
@kRHYME7 using ags . The creators dotfiles Looks like everything is covered. There is notification center, osd and bar Ags replaces waybar, swaync, nwg-drawer, rofi
im using ags like this right now
im testing HyprPanel for 2 days now...had some minor bugs but i fixed that easily and now working fine
Got more bugs from hyprpanel, but overall we can support wallbash and theming. So HyDE + HyprPanel is achievable.
Port of prasanthrangan/hyprdots#1818 ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below)
Port of prasanthrangan/hyprdots#1818 ## Type of change - [ ] **Bug fix** (non-breaking change which fixes an issue) - [x] **New feature** (non-breaking change which adds functionality) - [ ] **Breaking change** (fix or feature that would cause existing functionality to not work as expected) - [ ] **Documentation update** (non-breaking change; modified files are limited to the documentations) - [ ] **Technical debt** (a code change that does not fix a bug or add a feature but makes something clearer for devs) - [ ] **Other** (provide details below)
Pull Request
Description
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply: