-
Notifications
You must be signed in to change notification settings - Fork 121
When iterating a data file, loop back to the beginning... #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...peat the last element
Note: I tried to write a test, but was unsuccessful. I wasn't sure how I could just unit test the getIterationData method without exposing it. I tried
var expect = require('chai').expect,
Waterfall = require('../../lib/runner/extensions/waterfall.command.js');
describe('runner extensions', function () {
describe('Waterfall', function () {
describe('getIterationData', function () {
describe('when iteration count is less than the size of the data', function () {
it('should return the index of the data', function () {
var data = [
{ a: 'b' },
{ c: 'd' },
{ e: 'f' }
];
expect(Waterfall.getIterationData(data, 1)).to.eql({ c: 'd' });
});
});
describe('when iteration count is more than the size of the data', function () {
it('should loop back around to the beginning of the data', function () {
var data = [
{ a: 'b' },
{ c: 'd' },
{ e: 'f' }
];
expect(Waterfall.getIterationData(data, 2)).to.eql({ e: 'f' });
expect(Waterfall.getIterationData(data, 3)).to.eql({ a: 'b' });
expect(Waterfall.getIterationData(data, 5)).to.eql({ e: 'f' });
expect(Waterfall.getIterationData(data, 7)).to.eql({ c: 'd' });
});
});
});
});
});
Codecov Report
@@ Coverage Diff @@ ## develop #1218 +/- ## =========================================== - Coverage 79.57% 79.56% -0.02% =========================================== Files 42 42 Lines 2972 2970 -2 Branches 856 855 -1 =========================================== - Hits 2365 2363 -2 Misses 607 607
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@codenirvana
codenirvana
force-pushed
the
develop
branch
from
April 2, 2024 05:19
b5fc76a to
2717d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than repeat the last element. For example, take the following data file:
If I were to run a collection with the following GET API: https://postman-echo.com/get?foo1={{inputData}} using the runner, several things happen:
the current behavior is to run once with foo and 4 times with bar. For data seeding, this is not ideal. this enhancement causes the iteration count, if greater than the number of rows in the data, to return to the first index of the data file and continue to invoke the APIs in the collection.
image