-
Notifications
You must be signed in to change notification settings - Fork 96
Sharding key updates #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharding key updates #555
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the special handling of rows == 1 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support inserts with >1 row so I special cased it to throw a fit when rows > 1, since if we DELETED 10 for example, we can't INSERT ... in a sharded context basically. I will probably try to get multirow inserts to work next, I think that's a big blocker for sharding, but I think it needs a li'l refactor, all these special cases are getting complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
image
#541
This version just raises an error when sharding key updates are detected. Will add the actual rewriting shortly.