-
Notifications
You must be signed in to change notification settings - Fork 96
Add 'Fail' mode when no shard selected #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: christoudias <2363711+christoudias@users.noreply.github.com>
CLAassistant
commented
Jun 27, 2025
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Co-authored-by: christoudias <2363711+christoudias@users.noreply.github.com>
@Copilot
Copilot
AI
changed the title
(削除) [WIP] Add 'Fail' mode when no shard selected (削除ここまで)
(追記) Add 'Fail' mode when no shard selected (追記ここまで)
Jun 27, 2025
Copilot finished work on behalf of
christoudias
June 27, 2025 19:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This implements a "Fail" mode when no shard is selected, equivalent to pgcat's MR #859. When enabled, applications must explicitly select a shard for every connection, preventing data compromise in multi-tenant scenarios.
Problem
In multi-tenant applications using shards as tenants, it's critical that every query explicitly selects the correct shard. Without this requirement, queries may inadvertently access data from all shards, leading to potential data compromise and cross-tenant data leakage.
Solution
Added a new configuration option
require_shard_selection
that enforces explicit shard selection:When enabled, queries without explicit shard selection will fail with a
ShardSelectionRequired
error.Valid shard selection methods
/* pgdog_shard: 1 */ SELECT * FROM users
SET pgdog.shard TO 1; SELECT * FROM users
/* pgdog_sharding_key: user_123 */ SELECT * FROM users
Implementation details
require_shard_selection: bool
configuration option to[general]
sectionShardSelectionRequired
error variant to the parser error enumfalse
)Example
With this configuration:
SELECT * FROM users
→ fails withShardSelectionRequired
/* pgdog_shard: 1 */ SELECT * FROM users
→ routes to shard 1SET pgdog.shard TO 0; SELECT * FROM users
→ routes to shard 0Testing
All existing tests pass and new tests verify the functionality works correctly with various query types and shard selection methods.
Fixes #221.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.