-
-
Notifications
You must be signed in to change notification settings - Fork 533
Adding inverse sine function #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding new constant "inverseSin" into class "MonoOperatorModes". Adding new if statement "if (newMode == MonoOperatorModes.inverseSin)" into class "calculateMono"
The outputs of CalculateMonoSinTest(), CalculateMonoCosTest(), and CalculateMonoTanTest() were not matched with the expected answers because of the logic error. The logic error was solved by adding "Math.toDegrees()" Adding CalculateMonoInverseSinTest() to test the inverse sine function
jorianCheong
commented
Aug 9, 2022
@pH-7 @achinthagunasekara @hczhcz @xatza please to review my pull request, thank you very much
Thanks very much for this! I really appreciate your time improving the project! 💯
Could you let me know on what Java version you have tested your changes?
PS, can you commit SimpleJavaCalculator.jar containing your changes, and run it?
To do so, you can generate a new jar file with the following CLI command when you are in the src/ directory jar cmvf ../manifest.mf ../SimpleJavaCalculator.jar simplejavacalculator/*.class
pH-7
commented
Aug 13, 2022
Let me know if you need any help @jorianCheong 🙂 Hopefully what I suggested makes sense to you 😀
pH-7
commented
Oct 26, 2022
Hi @jorianCheong 🙂 I hope you are well!
Would you still be willing to finish this one, so you can get your PR merged?
Could you let me know when you can?
@pH-7
pH-7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Could you let me know on what Java version you have tested your changes?
-
Can you commit
SimpleJavaCalculator.jarcontaining your changes, and run it?
To do so, you can generate a new jar file with the following CLI command when you are in thesrc/directoryjar cmvf ../manifest.mf ../SimpleJavaCalculator.jar simplejavacalculator/*.class
Adding new constant "inverseSin" into class "MonoOperatorModes".
Adding new if statement "if (newMode == MonoOperatorModes.inverseSin)" into class "calculateMono"