-
Notifications
You must be signed in to change notification settings - Fork 353
Implement variant-aware dependency comparison for the GradleInspector #10979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Align with other interface functions that also omit the "Dependency" part. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Group functions for dependencies. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
c361f96 to
2804d42
Compare
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Skip deep comparison of transitive dependencies if dependency variants are the same. Resolves #9763. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
2804d42 to
56c3eb2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@ ## main #10979 +/- ## ============================================ + Coverage 57.49% 57.59% +0.09% - Complexity 1705 1708 +3 ============================================ Files 346 346 Lines 12841 12877 +36 Branches 1214 1214 ============================================ + Hits 7383 7416 +33 - Misses 4992 4994 +2 - Partials 466 467 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks go to @jjohannes for the ground work in his PoC PR!
Please have a look at the individual commit messages for the details.