-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix font CSS variable injection for fonts loaded from font panel #2916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been ignored for the connected project wowaemfasoptxrdjhilu
because there are no changes detected in apps/backend/supabase
directory. You can change this behaviour in Project Integrations Settings ↗︎.
Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.
Co-authored-by: Kitenite <31864905+Kitenite@users.noreply.github.com>
Co-authored-by: Kitenite <31864905+Kitenite@users.noreply.github.com>
@Copilot
Copilot
AI
changed the title
(削除) [WIP] [bug] Fonts loaded from the font panel are not implemented correctly (削除ここまで)
(追記) Fix font CSS variable injection for fonts loaded from font panel (追記ここまで)
Sep 25, 2025
Copilot finished work on behalf of
Kitenite
September 25, 2025 06:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Problem
When users selected fonts from the font panel, the fonts were often only partially implemented and didn't work correctly with Tailwind CSS classes. The system was properly:
But it was missing the critical step of injecting CSS variables into the user's
globals.css
file.This meant that Tailwind font classes like
font-inter
would fail becausevar(--font-inter)
was undefined in the CSS.Solution
Added a new
CSSManager
class that automatically injects CSS variables into the user'sglobals.css
file when fonts are added through the font panel.Before the fix:
After the fix:
Key Features
--font-{id}: '{family}', sans-serif;
globals.css
files (fonts still work via WebFont loading)globals.css
in common Next.js locations (src/styles/
,styles/
,src/app/
, etc.)Implementation Details
CSSManager
- New class that handles CSS variable injection/removalFontManager
- Integrated CSS manager into existing font workflowglobals.css
in standard locations:root
selector with proper fallbacksTesting
CSSManager
This fix ensures that fonts loaded from the font panel are immediately functional and can be used with Tailwind CSS classes without any additional manual configuration.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.hubspotusercontent40.net
If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.