-
Notifications
You must be signed in to change notification settings - Fork 888
added login page #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
added login page #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging bed6777 into fdc887a - view on LGTM.com
new alerts:
- 1 for Disabled Spring CSRF protection
corrected issue caused by enabling http.csrf() that was not caught in initial testing.
fixed issue with delete topic after http.csrf() was enabled with addition of login screen
xtruan
commented
Dec 10, 2021
I have tested this enhancement (verifying login prompt, creating topics, deleting topics, etc.) at my organization and we have incorporated into our Kafdrop instance. Thanks!
Hongten
commented
Jul 29, 2024
How about using Google Auth to log in to the system?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a requirement on my end to secure access to Kafdrop via a login page. I am submitting this code for your review / approval. This is a simple login solution, only supporting a single user.
Default:
Override via command line args (validated in docker/docker-compose as well):
image