-
Notifications
You must be signed in to change notification settings - Fork 40.7k
Fix: Prevent mason-lspconfig crash + highlight key fix #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix mason-lspconfig crash Explicitly sets: automatic_enable = false This prevents a known issue in recent versions of mason-lspconfig where a nil `enable()` function causes a crash. Keeping this disabled in Kickstart improves stability for new users. 2. Fix highlight key typo A previous commit changed `highlight` to `hl` in the `on_yank` autocmd, but related code still used `highlight`, causing inconsistency. This commit restores consistency. Feel free to revise the preferred style.
- We already have a few similar PRs such as feat: improved lsp setup for nvim > 0.11 #1590 .
hlis not a typo.highlightchanged tohlin nvim 0.11.x. You should use 0.11.x.
Got it👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mason-lspconfig crash Explicitly sets: automatic_enable = false This prevents a known issue in recent versions of mason-lspconfig where a nil
enable()function causes a crash. Keeping this disabled in Kickstart improves stability for new users.Fix highlight key typo A previous commit changed
highlighttohlin theon_yankautocmd, but related code still usedhighlight, causing inconsistency. This commit restores consistency. Feel free to revise the preferred style.