-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(linter): install correct deps in eslint convert to flat config generator #33078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+53
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@leosvelperez
leosvelperez
changed the title
(削除) Misc/fix nightly failures npm peer deps (削除ここまで)
(追記) cleanup(misc): fix nightly e2e failures (追記ここまで)
Oct 15, 2025
|
View your CI Pipeline Execution ↗ for commit de19d01
☁️ Nx Cloud last updated this comment at |
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 16, 2025 11:57
8c223b3 to
5a3a0f8
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 16, 2025 14:55
5a3a0f8 to
bcd7197
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 17, 2025 08:29
bcd7197 to
cf68b9e
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 17, 2025 08:43
cf68b9e to
cffe040
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 17, 2025 09:08
cffe040 to
5f85427
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 17, 2025 11:25
5f85427 to
3a550df
Compare
@leosvelperez
leosvelperez
force-pushed
the
misc/fix-nightly-failures-npm-peer-deps
branch
from
October 17, 2025 11:39
3a550df to
de19d01
Compare
@leosvelperez
leosvelperez
changed the title
(削除) cleanup(misc): fix nightly e2e failures (削除ここまで)
(追記) fix(linter): install correct deps in eslint convert to flat config generator (追記ここまで)
Oct 17, 2025
@leosvelperez
leosvelperez
requested review from
a team,
FrozenPandaz,
MaxKless,
lourw,
meeroslav and
vsavkin
as code owners
October 17, 2025 11:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Installs the correct dependencies after converting to the ESLint Flat configuration. This was highlighted after removing the npm
--legacy-peer-depsflag from default usage in Nx.Additionally, it fixes nightly e2e failures:
e2e-esbuilde2e-eslinte2e-gradlee2e-jse2e-webe2e-webpackNightly run where all pass: https://github.com/nrwl/nx/actions/runs/18587274772