-
Notifications
You must be signed in to change notification settings - Fork 605
Adding Laravel Vapor Support - Fixes #716 #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this work for both laravel and static types (the asset URLs especially)? Also, build is failing. See https://travis-ci.org/github/mpociot/laravel-apidoc-generator/jobs/673463648. You'll need to add an exception for that error in the phpstan.neon (follow the existing examples).
The asset() function is a blade function. I didn't touch the static files, since it's my understanding that they do work with Vapor. The only exception is the postman collection. Wich will be fixed as long as they use the s3 disk.
I just committed the ignore errors as requested
Uh oh!
There was an error while loading. Please reload this page.
Hello,
I added Laravel Vapor Support.
The changes were relatively simple:
Storageclass now use the disk referenced in the config file.all.cssandall.jsto use theasset()function, since it generates a URL for an asset using the current scheme of the request (HTTP or HTTPS). In case of Vapor users, it will automatically reference the correct url for static files in AWS.