-
Notifications
You must be signed in to change notification settings - Fork 272
askama 0.13->0.14. Significant as all filter function signatures change. #2621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All filter functions now take at least 2 args; the new 2nd arg is now typically `_: &dyn askama::Values`.
They increased the MSRV to Rust 1.83.0 in that release: askama-rs/askama@04a4d5b
m-c is at 1.82.0 for now: https://searchfox.org/mozilla-central/rev/67ff378efd69fbfb26d47ee4d9d0d249ab4be1d5/Cargo.toml#62-63
That might change by the time we get an UniFFI update into m-c, but would be a blocker for now.
Hi folks, any updates on an ETA for this getting merged?
I just checked the status in moz-central and it looks like they're working to bump the MSRV version right now. I'd expect a fix in the next few weeks, but it's hard to estimate. My guess is that we'll release 0.30.0 with the current askama version, but maybe 0.30.1 could bump it.
All filter functions now take at least 2 args; the new 2nd arg is now typically
_: &dyn askama::Values. Theaskama::Valuesconcept seems good in general.@badboy @bendk this is going to be a little painful, but I guess we have to take this eventually so uniffi .30 seems like it should be fine? We'll probably need to upgrade nimbis-fml at the same time.