-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Bugifx MTE-4921 Put app.launch() back to feature flagged test cases #30045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to close URL bar now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the line then or add a comment why it would be commented out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is not run as a part of the smoke tests. If it's run against the PR, we should catch the issue.
💪 Quality guardian
3 tests files modified. You're a champion of test coverage! 🚀
🧹 Tidy commit
Just 3 file(s) touched. Thanks for keeping it clean and review-friendly!
✅ Per-file coverage
All changed files meet the threshold of 35.0%.
Generated by 🚫 Danger Swift against 541d839
2eb845b to
541d839
Compare
🚀 PR merged to main, targeting version: 144.2
📜 Tickets
Jira ticket
💡 Description
Although some tests have their feature flags removed, we still need
app.launch()in the tests.(I have not gone through all test failures yet. More fixes may come.)
🎥 Demos
Demo
📝 Checklist