Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Refactor FXIOS-12831 [Swift 6 Migration] MainActor SummarizerMiddleware #30042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@lmarceau lmarceau commented Oct 15, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

SummarizerMiddleware is now MainActor and use dispatch instead of dispatchLegacy

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@lmarceau lmarceau requested a review from a team as a code owner October 15, 2025 20:31
Copy link

Messages
📖 Project coverage: 38.4%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.18

File Coverage
SummarizeMiddleware.swift 84.62% ✅

Generated by 🚫 Danger Swift against ec94987

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

lmarceau reacted with heart emoji
@lmarceau lmarceau merged commit bbd6778 into epic-branch/swift-6-redux-migration Oct 16, 2025
9 checks passed
@lmarceau lmarceau deleted the lm/SummarizerMiddleware branch October 16, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@issammani issammani issammani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /