-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add FXIOS-13734 [Trending Searches] check for hiding quick search engines #30035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cyndichin
merged 3 commits into
main
from
cc/FXIOS-13734_remove-search-engine-selection-from-zero-search
Oct 16, 2025
Merged
Add FXIOS-13734 [Trending Searches] check for hiding quick search engines #30035
cyndichin
merged 3 commits into
main
from
cc/FXIOS-13734_remove-search-engine-selection-from-zero-search
Oct 16, 2025
+126
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cyndichin
cyndichin
force-pushed
the
cc/FXIOS-13734_remove-search-engine-selection-from-zero-search
branch
from
October 15, 2025 18:25
2be8312 to
cd8c65b
Compare
mobiletest-ci-bot
commented
Oct 15, 2025
💪 Quality guardian3 tests files modified. You're a champion of test coverage! 🚀 🥇 Perfect PR sizeSmaller PRs are easier to review. Thanks for making life easy for reviewers! ✨ 💬 Description craftsmanGreat PR description! Reviewers salute you 🫡 ❌ Per-file test coverage gateThe following changed file(s) are below 35.0% coverage:
Client.app: Coverage: 37.21
Generated by 🚫 Danger Swift against cd8c65b |
thatswinnie
thatswinnie
approved these changes
Oct 16, 2025
@cyndichin
cyndichin
deleted the
cc/FXIOS-13734_remove-search-engine-selection-from-zero-search
branch
October 16, 2025 14:37
🚀 PR merged to main, targeting version: 144.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
I broke these up into separate commits to view easier. Felt they were small enough to not be in separate PRs.
Note: To test feel free to turn on the trending searches feature in debug menu under
Search - Trending.🎥 Demos
Simulator.Screen.Recording.-.iPhone.16e.-.2025年10月15日.at.12.38.41.mov
📝 Checklist