Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add FXIOS-29098 [Bookmarks] The Folder's name is visible #30006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
issammani merged 1 commit into mozilla-mobile:main from esraakhaled:fix-name-of-folder
Oct 16, 2025

Conversation

Copy link
Contributor

@esraakhaled esraakhaled commented Oct 14, 2025 •
edited by Foxbolts
Loading

📜 Tickets

Jira ticket
Github issue

Description

The PR makes The folder’s name is visible.

Solution

Simulator Screenshot - iPhone 17 Pro - 2025年10月14日 at 13 02 25

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

issammani reacted with heart emoji
Copy link
Contributor

@yoanarios yoanarios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 🚀 and I tested and it is working as expected

esraakhaled reacted with heart emoji
Copy link
Contributor

yoanarios commented Oct 15, 2025 •
edited by Foxbolts
Loading

I'm just going to wait for @Foxbolts approval because he has more context in case I miss something

Simulator Screenshot - iPhone 17 - 2025年10月15日 at 11 34 17 Simulator Screenshot - iPhone 17 - 2025年10月15日 at 11 34 20

Copy link

Messages
📖 Project coverage: 38.49%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.2

File Coverage
OneLineTableViewCell.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 7adf76b

@issammani issammani self-requested a review October 16, 2025 12:42
Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @esraakhaled !

esraakhaled reacted with heart emoji
@issammani issammani merged commit 5516aef into mozilla-mobile:main Oct 16, 2025
9 checks passed
Copy link
Contributor

🚀 PR merged to main, targeting version: 144.2
esraakhaled reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoanarios yoanarios yoanarios approved these changes

@issammani issammani issammani approved these changes

@Foxbolts Foxbolts Awaiting requested review from Foxbolts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /