Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

icon color: bluesky, instagram, threads, tiktok, x, youtube #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codelabor wants to merge 8 commits into mmistakes:master
base: master
Choose a base branch
Loading
from codelabor:master

Conversation

Copy link

@codelabor codelabor commented Jan 27, 2025

This is an enhancement or feature.

Summary

Positioned the brand icon below in alphabetical order

  • youtube

Added color for the brand icon below

  • blueskey

Modified the color for the brand icon below

  • instagram

Added a square class to the brand icon below

  • instagram

Color crashed for the brand icon below, so I consolidated it into one setting

  • threads
  • tiktok
  • x

{% endif %}
</div>

{% if author %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unnecessary. We're already using {% if author.avatar %} above, so either the build errors out, or this check always passes.

Copy link
Author

@codelabor codelabor Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of author.avatar's conditional statement.
The intention is to prevent the following phenomenon.

[Intended situation]

  • I want to mark the avatar.
  • I don't want to show links.

[Actual results]

  • Avatar is displayed. (It's OK)
  • Links are not displayed. (It's OK)
  • However, when the screen is reduced, the 'Follow' button is displayed for no use.' (Why?)
  • Even if I click the 'Follow' button, there are no links to display, so I only see empty spaces. (Why?)

[Conclusion]
In the end, the phrase {%ifauthor%} was used to turn on/off the "url wrapper" that determines the "follow" button display.
If there is a better way, it doesn't matter if you write another conditional statement.

What I wanted to do was disable url wrapper because if there is no information to follow, such as links and sns accounts, there is no reason for the 'follow' button to be displayed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced this will work as intended. For {% if author %} to fail, you must omit the entire author key (so it evaluates to nil). In this case, there's no way to display an avatar.

SINGLE PAGE/POST
========================================================================== */

#main {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are incomprehensible. Please revert.

Copy link
Author

@codelabor codelabor Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems a little strange.
It was the 92nd line I was going to add the code below.

h2:first-of-type {
 margin-top: 0em;
}

The reason why I need to put that setting in is as follows.

[AS-IS]
The height of the profile panel on the left and the TOC panel on the right are the same, but the height of the content panel in the middle is slightly lower.
This is because the margin-top of the h2 tag is applied.
The margin-top of the h2 tag should be applied from the use of the second h2 tag.

[TO-BE]
The margin-top of h2 used for the first time on the intermediate content panel shall not be set.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the git diff is still incomprehensible. Please revert the unnecessary part and make sure the diff accurately reflects your changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, :first-of-type might not be as appropriate as :first-child, in case the content starts with something else. For example, I usually start my blog article with a regular paragraph.

Copy link
Author

@codelabor codelabor Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then how about this?

/* vertical alignment for first content */
:first-child,
aside + :nth-child(2) {
margin-top: 0em;
}


/* vertical alignment for first content */
:first-child,
aside + :nth-child(2) {
Copy link
Collaborator

@iBug iBug Jan 31, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These (削除) two (削除ここまで) three lines are over-indented by 2 spaces (1 level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iBug iBug iBug requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /