-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix handling of maxtasksperchild in ParallelExt for better compatibil... #1939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ity with joblib backend
@github-actions
github-actions
bot
added
the
waiting for triage
Cannot auto-triage, wait for triage.
label
May 27, 2025
@Abhijais4896
Abhijais4896
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def init(self, *args, **kwargs):
maxtasksperchild = kwargs.pop("maxtasksperchild", None)
super(ParallelExt, self).init(*args, **kwargs)
if isinstance(self._backend, MultiprocessingBackend):
if isinstance(self._backend, MultiprocessingBackend) and maxtasksperchild is not None:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fix: Improve
ParallelExtCompatibility withjoblibBackendDescription
This PR fixes the handling of
maxtasksperchildinParallelExt, ensuring better compatibility when using thejoblibbackend. The update ensures that task management behaves consistently under different multiprocessing settings.Motivation and Context
Previously,
maxtasksperchildwas either not respected or caused unexpected behavior under thejoblibbackend. This change ensures that task recycling and memory/resource constraints are correctly handled when running long or parallel workflows.How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyPlease confirm the above after testing.
Screenshots of Test Results (if appropriate)
(You can attach console output or screenshots here if needed)
Types of Changes