-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore(trace-viewer): improve aria tab roles #37872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use vbox and hbox for flex containers. What do you mean by height: 100% in a flex parent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're questioning about height: 100%. flex does not fill the off dimension by default; you have to tell the element to expand to fit.
Test results for "MCP"
1 failed
❌ [chrome] › mcp/test-debug.spec.ts:166 › test_debug (pause/snapshot/resume) @mcp-macos-15
2569 passed, 108 skipped
Merge workflow run.
Test results for "tests 1"
1 failed
❌ [playwright-test] › reporter-html.spec.ts:362 › created › should use different path if attachments base url option is provided @macos-latest-node18-2
3 flaky
47082 passed, 815 skipped
Merge workflow run.
Uh oh!
There was an error while loading. Please reload this page.
Addresses microsoft/playwright.dev#1806 and microsoft/playwright.dev#1807