-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: allow local-network-access permission in chromium #37871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure if we want to support this, given that "permission prompt for Local Network Access" is still an [opt-in experiment]( permission prompt for Local Network Access) in Chrome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is good. It looks like LNA is going to be enabled by default in 142 (https://chromestatus.com/feature/5152728072060928), so unblocking this usecase is nice. I am afraid that we'll have to disable it if too many customers are affected in the next release.
Can we add a test, or is that too hard given the IP shenanigans?
Thank you for the quick turnaround on this!
I am afraid that we'll have to disable it if too many customers are affected in the next release.
I commented about this here: #37861 (comment)
My gut feeling is that most people won't be affected by this because they will likely fall into "all private" or "all public" buckets of access patterns. We were affected because our desire for consistent infrastructure between dev/staging/prod meant putting the root URL behind CF (technically making it public) while other services were kept private.
But it will be nice to have an escape hatch for those of us in the unconventional "public -> private" bucket.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c89ece1 to
f02fa79
Compare
Test results for "tests 1"
2 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:204 › should not preserve selection across test runs @macos-latest-node18-1
2 flaky
47095 passed, 815 skipped
Merge workflow run.
Uh oh!
There was an error while loading. Please reload this page.
Feature status: https://chromestatus.com/feature/5152728072060928 Looks like it got enabled between 1.56.0-alpha-2025年09月12日 and 1.56.0-alpha-2025年09月11日 which correspond to Chromium 141.0.7390.16 and 141.0.7390.7.
Blink thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/cwu_RUmBpzY?utm_source=chatgpt.com&pli=1
Fixes #37861