-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix streamable-http session management with minimal change #37866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replace immediate session cleanup with 5-second delayed cleanup to prevent 'Session not found' errors during multi-step browser automation operations. This is the minimal fix that resolves the core issue without over-engineering.
Test results for "MCP"
3 failed
❌ [chromium] › mcp/test-debug.spec.ts:232 › test_debug / evaluate x 2 @mcp-macos-15
❌ [chrome] › mcp/cdp.spec.ts:20 › cdp server @mcp-windows-latest
❌ [chrome] › mcp/cdp.spec.ts:31 › cdp server reuse tab @mcp-windows-latest
2554 passed, 108 skipped
Merge workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please start with filing a bug report that would describe the issue you are trying to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it'll be deleted eventually, that does not sound right. Please add a test.
Replace immediate session cleanup with 5-second delayed cleanup to prevent 'Session not found' errors during multi-step browser automation operations.
This is the minimal fix that resolves the core issue around streamable-http transport support.
When combined with the playwright-mcp PR, these two changes will fix the "navigate to google, type banana into the search bar, click search and take a screen shot of the result" scenario without a session being dropped when using it in a pod.