-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(test runner): config.tag for a global tag #37846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test results for "tests 1"
2 failed
❌ [playwright-test] › runner.spec.ts:118 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [playwright-test] › reporter-html.spec.ts:3006 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2
2 flaky
47017 passed, 816 skipped
Merge workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's include platform name in the example: ['@apiv2', 'linux']. This is important for the case of running the same project on multiple platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's include tags into the inputs for the hash - for the case when the tags are long and we may end up with clashing 50 chars prefixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we read the tags from the config event instead of storing them in the name?
No description provided.