-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Make reportSlowTests operate on tests, not test files
#37778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make reportSlowTests operate on tests, not test files
#37778
Conversation
reportSlowTests operate on tests, not test files (追記ここまで)
e8277bc to
75cf298
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"
1 failed
❌ [playwright-test] › reporter-html.spec.ts:724 › created › should warn user when viewing via file:// protocol @macos-latest-node18-2
4 flaky
46919 passed, 816 skipped
Merge workflow run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this check is a good thing. To be entirely honest, I'm not even sure what the purpose of the feature is. Do you have a workflow in mind? Perhaps this should be better as a "sort by duration" feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one overrides on each retry. I think we should think about the right semantics when retries are present.
Closes #37724.
The current implementation of
reportSlowTests, contrary to what the name implies, operates on test files and is from a time whenfullyParallelwasn't yet a thing. Today, it does't really work when multiple workers andfullyParallelare used, which makes it useless for pretty much anybody.To bring the feature in line with its name, this PR replaces the implementation so that it operates on tests. This is technically a breaking change, but it's OK to break broken things.