-
Notifications
You must be signed in to change notification settings - Fork 564
enable gradient accumulation in SDD #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+62
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@meta-cla
meta-cla
bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 17, 2025
arsatis
pushed a commit
to arsatis/torchrec
that referenced
this pull request
Oct 17, 2025
Summary: Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models. This diff: implements a UI enabling gradient accumulation for SDD. Differential Revision: D84915986
@arsatis
arsatis
force-pushed
the
export-D84915986
branch
from
October 17, 2025 14:22
a4c8aeb to
c325906
Compare
arsatis
pushed a commit
to arsatis/torchrec
that referenced
this pull request
Oct 17, 2025
Summary: Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models. This diff: implements a UI enabling gradient accumulation for SDD. Differential Revision: D84915986
@arsatis
arsatis
force-pushed
the
export-D84915986
branch
2 times, most recently
from
October 17, 2025 15:18
f3c83ae to
1c720f4
Compare
arsatis
pushed a commit
to arsatis/torchrec
that referenced
this pull request
Oct 17, 2025
Summary: Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models. This diff: implements a UI enabling gradient accumulation for SDD. Differential Revision: D84915986
arsatis
pushed a commit
to arsatis/torchrec
that referenced
this pull request
Oct 17, 2025
Summary: Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models. This diff: implements a UI enabling gradient accumulation for SDD. Differential Revision: D84915986
@arsatis
arsatis
force-pushed
the
export-D84915986
branch
from
October 17, 2025 15:30
1c720f4 to
d54db72
Compare
Summary: Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models. This diff: implements a UI enabling gradient accumulation for SDD. Differential Revision: D84915986
@arsatis
arsatis
force-pushed
the
export-D84915986
branch
from
October 19, 2025 04:19
d54db72 to
377e8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: gradient accumulation is still not available in TorchRec, especially for the SDD pipeline which is being used by many recommendation models.
This diff: implements a UI enabling gradient accumulation for SDD.
Differential Revision: D84915986