-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add many missing CSS property values (added since ~2015) #28138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).
Will this change the baseline for any features? I'm also a little bit worried about how big this'll make some of the support tables, but that's probably fine. Nice work!
Thanks!
Theoretically, Baseline should not change for any of the features, since any features introduced in versions later than the base property itself would probably get a different tag. But we'll see when the Web Platform DX group tags them!
As for the table size, most of the properties shouldn't see their tables grow much, as only a handful of values are added. There are a few properties where a lot of values are added, but I think that they're all relevant to list!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and plausible to me overall.
I noticed that some spec URLs are missing though!?
Yeah, I mentioned the reason why lots of spec URLs were missing in the PR description:
Spec URLs: csswg.org went down frequently during the creation of this PR. Some spec URLs could not be obtained while the website was down.
I do intend to add them in, hopefully when I do, the CSSWG website will be fixed!
Alright, got all the ones that I could track down added in! For any that are still not added, I was not able to find a link that was specific enough to the value, and wasn't sure if linking to the property instead would be good to do.
Alright, got all the ones that I could track down added in! For any that are still not added, I was not able to find a link that was specific enough to the value, and wasn't sure if linking to the property instead would be good to do.
For the ones without specific fragment, it would be best to have a link to the property with a text fragment pointing to the value. In Firefox Nightly (not sure about stable), this works by first clicking on the property anchor link, then select the value, and select Copy link to selection from the right-click context menu.
I didn't think we were allowing text fragments, but that makes sense! Alright, I'll get going on that and update this PR as soon as I can!
Alright, all missing spec URLs should be added now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the spec URL for the property, to account for thickness values:
Uh oh!
There was an error while loading. Please reload this page.
This PR is a part of a process to add all of the missing spec-defined CSS property values. These values are added by the mdn-bcd-collector, following an upgrade of Webref CSS to v7 and directly parsing the syntax for each property.
This specific PR focuses on CSS property values that were added in browser versions after ~2012. This PR includes a combination of values added when the properties were introduced, as well as values added afterwards. Any values that didn't seem plausible were omitted. Spec URLs were obtained for as many values as possible.
Notes:
(削除) Spec URLs: csswg.org went down frequently during the creation of this PR. Some spec URLs could not be obtained while the website was down. (削除ここまで)Spec URLs had been added later.isolation
Property: Opera was set to a later version (Opera 30 = Chrome 43) than the matching Chrome version (Opera 28 = Chrome 41). Because Opera 30 was from the original wiki migration, it was replaced with mirroring.block-size
andinline-size
Properties: Samsung Internet was set to 5.0, but in the PR that added it (Updating intrinsic sizing keywords data #3457 ), I found no supporting documentation for that version number. As such, to fix consistency, the data was treated as untrustworthy and replaced with mirroring.