-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bug-1625257 sync storage support in Android #28107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-1625257 sync storage support in Android #28107
Conversation
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested to set getBytesInUse to mirror, but not everything is visible in the diff. Please fix it up across the whole storage.json file and I'll review again.
webextensions/api/storage.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quota enforcement is only relevant to the set method, not to the other methods. I'm not sure if we should event document the lack of quota enforcement, as it is not exactly an intended feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rob--W now only mentions the issue in relation to sync and set.
Co-authored-by: Rob Wu <rob@robwu.nl>
Summary
This PR addresses feedback provided about method support in
syncstorage in Firefox for Android by:StorageArea.impl_urlandpartial_implementationproperties undersync.In addition, the support for
getBytesInUseundersessionstorage was corrected to indicate the method is not supported (it's not supported anywhere within Firefox for Android.)