-
-
Notifications
You must be signed in to change notification settings - Fork 638
feat: improve consistency of many arg with nested schema #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jafournier
wants to merge
1
commit into
marshmallow-code:dev
from
jafournier:feat/many_consistenty_between_nested_field_and_nested_schema_many
Open
feat: improve consistency of many arg with nested schema #2854
jafournier
wants to merge
1
commit into
marshmallow-code:dev
from
jafournier:feat/many_consistenty_between_nested_field_and_nested_schema_many
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jafournier
jafournier
changed the title
(削除) feat: many consistency between nested schema (削除ここまで)
(追記) feat: improve consistency of many arg with nested schema (追記ここまで)
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
For nested field, we can get some inconsistencies between
field.many
andfield.schema.many
.Here is a proposal to handle inconsistency edge cases (see tests).
PS: Such inconsistencies have some effects on automatic swagger generation in
flask_appbuilder
(and thus in projects using it, assuperset
).This will solve apache/superset#33884.