-
-
Notifications
You must be signed in to change notification settings - Fork 638
Fix load parameter *unknow* propagation #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lmignon
wants to merge
2
commits into
marshmallow-code:dev
from
lmignon:dev-fix-deserialize-unknown-in-nested
Open
Fix load parameter *unknow* propagation #1429
lmignon
wants to merge
2
commits into
marshmallow-code:dev
from
lmignon:dev-fix-deserialize-unknown-in-nested
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lmignon
lmignon
force-pushed
the
dev-fix-deserialize-unknown-in-nested
branch
from
November 2, 2019 11:05
3a986fc to
3d94ded
Compare
When deserializing a data structure with the load method, the *unknown* was not propagated to the loading of nested data structures. As result, if a unknown field was present into a nested data structure a ValidationError was raised even if the load methd was called with *unknown=EXCLUDE*. This commit ensures that this parameter is now propagated also to the loading of nested data structures. fixes marshmallow-code#1428
@lmignon
lmignon
force-pushed
the
dev-fix-deserialize-unknown-in-nested
branch
from
November 2, 2019 11:11
3d94ded to
e1acdd7
Compare
SVilgelm
SVilgelm
approved these changes
Nov 25, 2019
@SVilgelm
SVilgelm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, i have just one nit comment
SVilgelm
SVilgelm
approved these changes
Nov 25, 2019
@SVilgelm
SVilgelm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Sytten
Sytten
approved these changes
Nov 26, 2019
Nested.load() calls Schema.load() internally, so when an unknown argument is supplied to the Nested constructor, this PR causes all of the nested unknown options to be recursively overridden.
from marshmallow import fields, Schema, RAISE, INCLUDE, EXCLUDE class C(Schema): foo = fields.Str() class Meta: unknown = EXCLUDE class B(Schema): c = fields.Nested(C) class A(Schema): b = fields.Nested(B, unknown=INCLUDE) class Meta: unknown = RAISE schema = A() print(schema.load({ 'b': { 'extra': 'good', 'c': { 'foo': 'bar', 'unexpected': 'bad' } } }))
Current behavior (3.2.2):
{'b': {'c': {'foo': 'bar'}, 'extra': 'good'}}Proposed behavior:
{'b': {'c': {'foo': 'bar', 'unexpected': 'bad'}, 'extra': 'good'}}
sirosen
added a commit
to sirosen/marshmallow
that referenced
this pull request
Jul 17, 2020
The changelog entry, including credit to prior related work, covers the closed issues and describes how `propagate_unknown` is expected to behave. Inline documentation attempts to strike a balance between clarify and brevity. closes marshmallow-code#1428, marshmallow-code#1429, marshmallow-code#1490, marshmallow-code#1575
sirosen
added a commit
to sirosen/marshmallow
that referenced
this pull request
Jul 17, 2020
The changelog entry, including credit to prior related work, covers the closed issues and describes how `propagate_unknown` is expected to behave. Inline documentation attempts to strike a balance between clarify and brevity. closes marshmallow-code#1428, marshmallow-code#1429, marshmallow-code#1490, marshmallow-code#1575
sirosen
added a commit
to sirosen/marshmallow
that referenced
this pull request
Sep 4, 2020
The changelog entry, including credit to prior related work, covers the closed issues and describes how `propagate_unknown` is expected to behave. Inline documentation attempts to strike a balance between clarify and brevity. closes marshmallow-code#1428, marshmallow-code#1429, marshmallow-code#1490, marshmallow-code#1575
bhperry
commented
Aug 18, 2025
Any chance of this merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing a data structure with the load method, the unknown was not propagated to the loading of nested data structures. As result, if a unknown field was present into a nested data structure a ValidationError was raised even if the load methd was called with unknown=EXCLUDE. This commit ensures that this parameter is now propagated also to the loading of nested data structures.
fixes #1428