-
Notifications
You must be signed in to change notification settings - Fork 11
encode to utf-8 instead of latin-1 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
see 5 files with indirect coverage changes
📢 Thoughts on this report? Let us know!
Thank you very much for your PR! Unfortunately it fails to build, but there is hope, because more than half of the tests pass, so this suggests that with minor rewrites to the tests it may work fine again. I'll have a look.
I did not reply before but I did look into this and this involved more than minor rewrites for the remaining tests to pass.
I will eventually come back to it when I'll have time, and maybe AI is advanced enough now to actuallu be useful for this kind of bug fixing.
Uh oh!
There was an error while loading. Please reload this page.
to add support for e.g. Cyrillic characters in file names; untested, let's see if CI/CD passes :)
related to #13