-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Deprecated VirtualBox with warning #21631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @divysinghvi. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Can one of the admins verify this patch?
@nirs https://minikube.sigs.k8s.io/docs/drivers/ i was thinking since we say stuff like preferred , experimental on this docs page shouldn't we mention the deprecated one's also this could be useful for people who are new so that then focus on right drivers .
cmd/minikube/cmd/start.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should list the drivers available Per Platform,
I believe regstiry package might have a func that gives you Available Drviers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done the change this is how it looks now
✨ Using the virtualbox driver based on user configuration ❗ The 'virtualbox' driver is deprecated and will be removed in a future release. You can use alternative drivers: qemu2, vfkit, krunkit, parallels, docker, podman, ssh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can go back and make a similar fix to hyperkit warning (in a new PR), to make them look more similar:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i have to change the hyperkit one in a new pr i was waiting for this one to be confirmed if this looks good i can make the pr for the hyperkit one also thanks
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: divysinghvi , medyagh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
(削除) OWNERS (削除ここまで)[medyagh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
thank you @divysinghvi that looks better, yes you can create a follow up PR to make hyperkit and others do the same
I suggest the follow up Pr have a general func called
warnDriverDepricated
and that can have for loop that goes ever every Depricatred driverd and checks if that matches the selected driver.
and only differen thing there would be the message if needs to be different
/ok-to-test
yes that could be really useful in future cause since we have a lot of upcoming deprecated drivers as nirs and abjorklund were discussing like parallals etc actually i did make the hyperkit message change also but it's better to have a common function for this task will make change in that too
|
@divysinghvi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@medyagh why is integration test failing on this pr any clue??
minikube-pr-bot
commented
Oct 1, 2025
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21631 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 45.4s │ 44.3s │
│ enable ingress │ 17.0s │ 15.9s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube (PR 21631) ingress: 15.8s 15.8s 16.3s 15.8s 15.8s
Times for minikube ingress: 15.8s 19.8s 16.3s 16.8s 16.3s
Times for minikube start: 45.0s 44.5s 45.7s 45.7s 45.8s
Times for minikube (PR 21631) start: 46.0s 41.4s 44.3s 45.3s 44.4s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21631 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.5s │ 21.5s │
│ enable ingress │ 12.6s │ 11.0s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 22.2s 21.5s 20.9s 23.0s 19.9s
Times for minikube (PR 21631) start: 21.6s 20.9s 21.4s 22.4s 21.4s
Times for minikube ingress: 10.6s 15.6s 10.6s 13.6s 12.6s
Times for minikube (PR 21631) ingress: 11.6s 11.6s 10.6s 10.7s 10.6s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21631 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 19.8s │ 19.9s │
│ enable ingress │ 26.5s │ 23.5s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 24.1s 23.1s 39.1s 23.1s 23.1s
Times for minikube (PR 21631) ingress: 23.1s 23.1s 24.1s 23.1s 24.1s
Times for minikube (PR 21631) start: 19.9s 20.5s 19.5s 19.5s 20.2s
Times for minikube start: 20.5s 19.9s 20.1s 18.8s 19.5s
minikube-pr-bot
commented
Oct 1, 2025
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this? please keep the links to the docs. This make it very easy to find more info by clicking on the link in the shell, and it is not required for this change.
Uh oh!
There was an error while loading. Please reload this page.
This PR adds a deprecation warning for the VirtualBox driver, similar to the existing hyperkit deprecation warning. The VirtualBox driver will display a clear warning message to users indicating it will be removed in a future release and suggesting alternative drivers.
Before
Before
After
After suggested change
Fixes #21608