-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove the deprecated hyperkit driver #21603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nirs
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
e0e7337 to
b3aa2dc
Compare
The hyperkit driver does not support Apple silicon machines introduced in June 2020. There are no plans to add support for Apple silicon and it was replaced by the virtualization framework in the docker project. Building hyperkit requires the xcgo container with is not maintained for several years, and has many vulnerabilities. The docker-machine-driver-hyperkit requires root permissions. Currently minikube add the setuid bit to make this driver runnable by root by any user, obtaining user password with sudo. This is insecure and wrong in many ways. The minikube project does not have enough contributors to support legacy drivers. We want to spend time on making modern drivers better, providing value to most users. The driver is mark deprecated in minikube 1.37 and we want to remove it in minikube 1.38. macOS users with intel based machines can use other drivers: vfkit (preferred), qemu, or docker. macOS user with Apple silicon machine can also use the new krunkit driver (experimental).
b3aa2dc to
d26a373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there is urgency in removing this driver, we can continue warn and also remove it from being listed or advertised.
I actually do have mac device from 2010 and it still running and I do like to run minikube on it once in a while. so I dont think there is an urgency in removing it, since there are still x86 macbooks.
I dont think there is urgency in removing this driver, we can continue warn and also remove it from being listed or advertised. I actually do have mac device from 2010 and it still running and I do like to run minikube on it once in a while. so I dont think there is an urgency in removing it, since there are still x86 macbooks.
Keeping the driver make it harder to work on minikube. We are slowed down by having to deal with the hacks added to support it.
macOS 26 is the last version supporting intel macs. We don’t have the capacity to support older machine that Apple does not.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Uh oh!
There was an error while loading. Please reload this page.
The hyperkit driver does not support Apple silicon machines introduced
in June 2020. There are no plans to add support for Apple silicon and it
was replaced by the virtualization framework in the docker project.
Building hyperkit requires the xcgo container with is not maintained for
several years, and has many vulnerabilities.
The docker-machine-driver-hyperkit requires root permissions. Currently
minikube add the setuid bit to make this driver runnable by root by any
user, obtaining user password with sudo. This is insecure and wrong in
many ways.
The minikube project does not have enough contributors to support legacy
drivers. We want to spend time on making modern drivers better,
providing value to most users.
The driver is mark deprecated in minikube 1.37 and we want to remove it
in minikube 1.38.
macOS users with intel based machines can use other drivers: vfkit
(preferred), qemu, or docker. macOS user with Apple silicon machine can
also use the new krunkit driver (experimental).
Fixes #21601