-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Test/remove duplicate k8s versions #21501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/remove duplicate k8s versions #21501
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: vineetxkhurana
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Welcome @vineetxkhurana!
It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/minikube has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. 😃
Hi @vineetxkhurana. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Can one of the admins verify this patch?
This PR refactors Kubernetes version handling in integration tests by adding a helper function (GetKubernetesTestVersions) to
helpers_test.go
. The function ensures a unique, deduplicated list of Kubernetes versions for testing, so tests aren’t run multiple times for the same version. Theaaa_download_only_test.go
is updated to use this helper.Why this change?
Previously, tests could run redundantly if
DefaultKubernetesVersion
andNewestKubernetesVersion
were the same, leading to duplicate test runs.What did I change?
Added GetKubernetesTestVersions() to
test/integration/helpers_test.go
.Updated
test/integration/aaa_download_only_test.go
to use the new helper.Reference:
Addresses issue #21483.