-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add helper function to generate unique Kubernetes versions for testing #21499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @shubhanshu-02!
It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/minikube has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. 😃
Hi @shubhanshu-02. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Can one of the admins verify this patch?
Hey @nirs, did you check this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it would be more useful to squash the commits into one, since this is a small and simple change. We can squash the commits during merge, but this create ugly commit message that makes it header to inspect git history later.
Signed-off-by: shubhanshu-02 <shubhanshu004@gmail.com>
Follows up on issue #21483.
This should be:
Fixes #21483
Which will link this PR to the issue. When we merge the issue will be closed automatically.
75e3fc4 to
b480247
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nirs , shubhanshu-02
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@shubhanshu-02 thanks!
@medyagh merge?
@DeepDN
DeepDN
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good to me
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
This PR cleans up Kubernetes version array handling in the integration tests by introducing a helper function (
getKubernetesVersionsForTesting) inhelpers_test.go. This function builds a unique list of Kubernetes versions for use in tests, ensuring that DefaultKubernetesVersion and NewestKubernetesVersion are not both added if they are equal. The testaaa_download_only_test.gois updated to use this helper.Why is this needed?
Previously, duplicate versions could be present in test arrays if DefaultKubernetesVersion and NewestKubernetesVersion are the same, causing redundant test runs.
What did you change?
getKubernetesVersionsForTesting()totest/integration/helpers_test.go.test/integration/aaa_download_only_test.goto use the new helper.Reference
Fixes #21483.